KAFKA-9661: Propagate includeSynonyms option to AdminClient in ConfigCommand #8229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mumrah
approved these changes
Mar 5, 2020
| @@ -367,7 +367,7 @@ object ConfigCommand extends Config { | |||
| println(s"Completed updating default config for $entityType in the cluster.") | |||
| } | |||
|
|
|||
| private def describeConfig(adminClient: Admin, opts: ConfigCommandOptions): Unit = { | |||
| private[admin] def describeConfig(adminClient: Admin, opts: ConfigCommandOptions): Unit = { | |||
There was a problem hiding this comment.
Is this visibility just for testing?
There was a problem hiding this comment.
yes, the alterConfigs method above this had the same visibility too for the same reason.
| @@ -426,7 +426,9 @@ object ConfigCommand extends Config { | |||
| dynamicConfigSource | |||
|
|
|||
| val configResource = new ConfigResource(configResourceType, entityName) | |||
| val configs = adminClient.describeConfigs(Collections.singleton(configResource)).all.get(30, TimeUnit.SECONDS) | |||
| val describeOptions = new DescribeConfigsOptions().includeSynonyms(includeSynonyms) | |||
There was a problem hiding this comment.
I was going to ask about unused linter warnings to catch bugs like this, but turns out we have a problem in our build. Filed https://issues.apache.org/jira/browse/KAFKA-9665
|
LGTM. Thanks, @rajinisivaram |
mumrah
added a commit
that referenced
this pull request
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Committer Checklist (excluded from commit message)